Open Koncopd opened 1 month ago
Attention: Patch coverage is 82.35294%
with 9 lines
in your changes missing coverage. Please review.
Project coverage is 92.45%. Comparing base (
c41fc2c
) to head (523ece4
). Report is 4 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
lamindb/core/storage/_observations.py | 82.00% | 9 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Do we want it to be used by default?
This shouldn't be part of the Artifact API. If it's used internally while constructing the Artifact object, that's OK!
Can you more comprehensively document why this PR exists? The Slack link is internal and hence nobody external will understand why you're doing what you're doing here. ☺️
This looks perfectly great. We should just call this in Artifact()
by default if a corresponding path is called within say from_anndata()
.
Ok, makes sense. It still needs a bit of improvement though.
Should we also have .from_tiledbsoma
?
Ok, makes sense. It still needs a bit of improvement though. Should we also have .from_tiledbsoma?
Yes, I think so!
Re https://laminlabs.slack.com/archives/C04FPE8V01W/p1726658747846539
This function infers
n_obs
fromanndata
(bothzarr
andhdf5
) andtiledbsoma
. I am reluctant to add this toArtifact
by default though.