🚸 Rename `import_from_source()` to `import_source()`

laminlabs / lamindb

A data framework for biology.

https://docs.lamin.ai

Apache License 2.0

129 stars 12 forks source link

🚸 Rename `import_from_source()` to `import_source()` #2127

Closed falexwolf closed 2 weeks ago

falexwolf commented 3 weeks ago

The "from" can be confused with the "from" constructor and it doesn't add information.

Also aesthetically, the API would be nicer without it.

Of course, we'd need a deprecation period.

falexwolf commented 2 weeks ago

The naming choice somehow bothers me a ton in all the code snippets I see flying around.

With Lukas's new soft deprecation strategy, could we move forward with the renaming soon?

Do you agree import_source() is much better @sunnyosun @Zethson?

Zethson commented 2 weeks ago

I had assigned myself because I agree and can take care of this when I find some time.

sunnyosun commented 2 weeks ago

OK with me!

falexwolf commented 2 weeks ago

Great!

Lukas, can you prioritize given this is rather simple and potentially the last step towards converging ontology API design? Our goal is to lock in the API design ASAP and I don't see any other bad design choices we made (you tell me if I'm wrong).