search

laminlabs / lamindb

A data framework for biology.
https://docs.lamin.ai
Apache License 2.0
129 stars 12 forks source link

♻️ Only apply exact length uid constraint for internal entities #2167

Closed falexwolf closed 1 week ago

falexwolf commented 1 week ago

It turned out that in some use cases, it's meaningful to populate the uid field with an external id; e.g. from an ELN system.

Hence, we're only validating the internal ids.

Storage and users are exceptions because we might want to change the length at some point in the future (we changed the Storage uid length about 1 year ago from 8 to 12 chars).

This PR is a correction to the below PR:

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.61%. Comparing base (57fbd29) to head (ed8cc5b). Report is 27 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2167 +/- ## ========================================== + Coverage 92.53% 92.61% +0.07% ========================================== Files 55 54 -1 Lines 6467 6496 +29 ========================================== + Hits 5984 6016 +32 + Misses 483 480 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 week ago

🚀 Deployed on https://6734a587397331f565060b25--lamindb-qnwk.netlify.app