search

laminlabs / nbproject

Light-weight Jupyter notebook tracker.
https://lamin.ai/docs/nbproject
Apache License 2.0
34 stars 0 forks source link

♻️ Make ipylab an optional dependency #282

Closed falexwolf closed 4 months ago

github-actions[bot] commented 4 months ago

🚀 Deployed on https://663957c6ee93764e20591964--nbproject-ifta.netlify.app

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.35%. Comparing base (98974e1) to head (c50efa4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #282 +/- ## ========================================== + Coverage 89.22% 89.35% +0.13% ========================================== Files 24 24 Lines 1039 1033 -6 ========================================== - Hits 927 923 -4 + Misses 112 110 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Koncopd commented 4 months ago

Can we pause this until i analyse how to disentangle this properly?

Koncopd commented 4 months ago

We should have an extra for ipylab and a warning somewhere at least. But i don't think it makes sense at all to have nbproject without ipylab.

falexwolf commented 4 months ago

extra for ipylab

I hope we get away without ipylab. The jupyter lab extra is already too complicated, but we may need to keep it.