search

lammylol / Flock

New App Page for Flock
0 stars 0 forks source link

Notifications for comments #52

Closed ramonjiang closed 3 weeks ago

ramonjiang commented 4 weeks ago

theres some strange issue around permissions and users commenting on posts. i thought it was a firebase rules issue, but now im starting to think somthing needs to be tweaked in auth in code

ramonjiang commented 4 weeks ago

lets go!!!!!!!!

lammylol commented 3 weeks ago

Still reviewing because this is so big haha. Just sent out some initial comments.

lammylol commented 3 weeks ago

I'm not sure if this is the best entire way to do it, but I think we should start a new branch off of Notifications_for_Comments to implement the rest of these requirements: https://www.notion.so/Enable-In-App-Notifications-for-Comments-e6c6d80b692848f2b6cec960e83edbaa?pvs=4.

We can merge that once that's ready into this branch. That way we can test and make sure things are all working before integrating into Main. Since we don't have feature flags yet, we can't really separate out things from Main vs. what we ship to TestFlight if we find some issues that need further research. In other words.. trying to protect Main from having unfinished features that would cause a TestFlight user to question something.

ramonjiang commented 3 weeks ago

@lammylol made all changes as discussed here: https://www.notion.so/7a20c472b3bc4b50b79d57fdfdf22f73?v=03d735b576d64ca184e3daf0b4818ec8&p=13150a0c1d228072ba9bcc86efeb66e7&pm=s

ramonjiang commented 3 weeks ago

@lammylol LEGGO

ramonjiang commented 3 weeks ago

Last thing is to remove all the print statements and get logging in after we merge into main. Can be a follow up.

Ya. i can make a clean up branch after merge