search

lamorric / ai-contest

Automatically exported from code.google.com/p/ai-contest
0 stars 0 forks source link

Wrong message "<PlayerName> issued an order that could not be parsed." #189

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Run game where second bot issue wrong order

What is the expected output? What do you see instead?

Text message should display <PlayerName> for bot that issued wrong order. 
However, now it writes name of first player in game, not failed one.

What version of the product are you using? On what operating system?

Please provide any additional information below.

You may check games below
http://ai-contest.com/visualizer.php?game_id=5463190
http://ai-contest.com/visualizer.php?game_id=5463189
http://ai-contest.com/visualizer.php?game_id=5463301

This is displaying problem, judging seems works fine.

Original issue reported on code.google.com by dmitrisc...@gmail.com on 5 Oct 2010 at 6:25

GoogleCodeExporter commented 9 years ago 
I tried to help troubleshoot this issue, but it looks like the code in SVN is 
not the same as what is running in production.

The error strings are coming from www/game_info.php, which extracts them from a 
database table called 'errors'.  However, as of r503 
backend/tournament_manager.py does not seem to put anything in the errors 
table, and that is the only program in SVN which calls play_game in 
backend/engine.py.  So either tournament_manager.py has been modified in 
production or there is another program not in SVN which plays games, and that 
program is the one which has the bug.

Looking at the problem from the opposite direction, I see that 
www/api_record_game.php puts data into the errors table, but I don't see where 
that gets used by a program which actually runs games.

Is it possible that people are modifying production code directly instead of 
using version control?  If so, the community cannot possibly help fix bugs.

Original comment by jklan...@gmail.com on 23 Oct 2010 at 6:35

GoogleCodeExporter commented 9 years ago 
The code is in the 20100929-games-in-the-cloud branch.

Original comment by jklan...@gmail.com on 24 Oct 2010 at 2:21

GoogleCodeExporter commented 9 years ago 
The bug is a copy-and-paste error in the cloud version of the tournament 
manager.  Both players end up with player 1's id.  It was reported over on the 
IRC channel and it should be fixed soon.

players = [
  {"path" : player_one_path, "command" : player_one["command"], "submission_id": player_one["submission_id"]},
  {"path" : player_two_path, "command" : player_two["command"], "submission_id": player_one["submission_id"]}
]

Original comment by jklan...@gmail.com on 24 Oct 2010 at 2:50

GoogleCodeExporter commented 9 years ago 
Thanks jklandis for finding this. One more bug down.

Fixed in revision 451.

Original comment by janzert on 24 Oct 2010 at 2:55