search

lampe-games / godot-open-rts

Open Source RTS game made in Godot 4
https://lampe-games.itch.io/open-rts
MIT License
494 stars 70 forks source link

Make waiting units more aggressive and allows double clicking #96

Closed berndrakell closed 6 months ago

berndrakell commented 6 months ago

Closes #95 Also adds a property location to each unit, which holds the x and z value on the map. This property is often used in different scripts, so defining it in the unit itself is easier.

berndrakell commented 6 months ago

Also Closes #97 Added functionality to the SelectionHandler.gd, which now allows for selecting units of the same type with a double click.

Also adds property "type" to units, which equals their script/resource names (e.g. 'Tank')

Scony commented 6 months ago

Thank you! The change conceptually looks good to me - I'll make a few adjustments on top of that like changing names or extracting helper functions. Anyway, I'll merge it in upcoming days. Btw. In the future please open one PR per feature - it makes reviewing much easier :)

berndrakell commented 6 months ago

Thanks for the feedback. Yes I'll not do that again. Tbh I didn't know new commits automatically get joined in PRs - I was never so busy :D