Closed BarkingBad closed 3 years ago
@BarkingBad OK, I'm adding the issue with the ClassDef -> symbol -> tree
route to the litany of issues we need to open in Dotty repo post-merge.
I was trying to represent background colours to much these from the old scaladoc. These colours were matched with white font, so I followed that convenction either. However, it is nice to have links that actually can be navigable embedded into diagram. It would be hard for user to distinguish which parts of diagram are links, and which one are plain text. Could you propose style that you see would fit best, so we can discuss it?
@BarkingBad I see two options:
.diagram-class a:hover {
color: #BFE7F3;
}
I like the background colors, actually :slightly_smiling_face: They provide valuable and immediate information. Since it's quite intuitive that types in the diagram are clickable (when the link is resolved, at least), I think that underline+hint is enough. Therefore I would prefer option 1.
Thank you for your response @TheElectronWill. I also like option 1, so I will add your CSS snippet
As I rewrited pretty much previous PR and some comments became irrelevant, I decided to close previous PR and open new one to get fresh view on changes. However, I'd like to address two issues that still remain valid:
val parents = if smbl.exists then hackGetParents(classDef) else None
instead ofval parents = if smbl.exists then hackGetParents(smbl.tree.asInstanceOf[ClassDef]) else None
, am I correct? I tried to shortened that, and suprisingly for me these lines are not equal. I cannot guarantee the first diagram with my first approach is correct, but the second one is certainly not (example forscala3doc/example/level2/Documentation
)