lamps-wg / RFC5019bis

Use of SHA-256 for CertID
Other
0 stars 1 forks source link

add changes para to s1 #22

Closed seanturner closed 1 year ago

seanturner commented 1 year ago

Need to add new last para in s1 that highlights the changes made in this version of the document, because I know we'll get an IESG discuss on that point ;)

tadahik commented 1 year ago

I checked diff for 1st and last commit. I believe followings should be our contributions (I am not sure if we need to include all of minor fixes). On the reviewing process, I found some minor fix and I believe we should add Russ for acknowledgment so I will make new PR for that.

tadahik commented 1 year ago

I drafted text, but I feel like it is to detail, and we may curve out some of them (e.g. just say "fix syntax of http headers"), or bring changes to before security consideration.

https://github.com/tadahik/RFC5019bis/compare/changesFrom5019

seanturner commented 1 year ago

Oh I definitely think we do not need to be this detailed.

tadahik commented 1 year ago

Ok, I would leave that branch and make shorter one. I believe content of that branch may used for reviewing process later.

tadahik commented 1 year ago

I made shorter one. https://github.com/tadahik/RFC5019bis/compare/briefDesctiptionOfChanges

seanturner commented 1 year ago

LGTM!

tadahik commented 1 year ago

close with https://github.com/tadahik/RFC5019bis/pull/33