search

lamps-wg / dilithium-certificates

I-D that describes the algorithm identifiers for NIST's PQC Dilithium algorithm for use in the Internet X.509 Public Key Infrastructure
Other
6 stars 3 forks source link

Address #17 #18

Closed seanturner closed 3 months ago

seanturner commented 3 months ago

Addresses #17.

jakemas commented 3 months ago

Fixed merge conflict. @seanturner can you confirm that I addressed the conflict in the way you would have intended? If so, then I will merge!

seanturner commented 3 months ago

@jakemas belatedly lgtm!

jakemas commented 3 months ago

Thank you! If that’s all the changes merged, I can release a new WG version ahead of the weekend.

Cheers, Jake

From: Sean Turner @.> Reply-To: lamps-wg/dilithium-certificates @.> Date: Friday, July 19, 2024 at 12:03 PM To: lamps-wg/dilithium-certificates @.> Cc: "Massimo, Jake" @.>, Mention @.***> Subject: Re: [lamps-wg/dilithium-certificates] Address #17 (PR #18)

@jakemashttps://github.com/jakemas belatedly lgtm!

— Reply to this email directly, view it on GitHubhttps://github.com/lamps-wg/dilithium-certificates/pull/18#issuecomment-2239066097, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQHHONFDRO6SVHX3RZFTVVDZNEDRHAVCNFSM6AAAAABKS4XDOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZZGA3DMMBZG4. You are receiving this because you were mentioned.Message ID: @.***>

seanturner commented 3 months ago

Feel free to spin a new version when you get chance.

jakemas commented 3 months ago

I did try late Friday night to give you an official version over the weekend (see release 4). But it seems the github workflow has broken, and it wasn’t uploading the new releases. I pulled in new version of the github template we are using, but it didn’t fix the issue. :(

From: Sean Turner @.> Reply-To: lamps-wg/dilithium-certificates @.> Date: Monday, July 22, 2024 at 10:25 AM To: lamps-wg/dilithium-certificates @.> Cc: "Massimo, Jake" @.>, Mention @.***> Subject: Re: [lamps-wg/dilithium-certificates] Address #17 (PR #18)

Feel free to spin a new version when you get chance.

— Reply to this email directly, view it on GitHubhttps://github.com/lamps-wg/dilithium-certificates/pull/18#issuecomment-2243457030, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQHHONEHP6BU5RKWURW2SHDZNU57BAVCNFSM6AAAAABKS4XDOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBTGQ2TOMBTGA. You are receiving this because you were mentioned.Message ID: @.***>

seanturner commented 3 months ago

The submission window was closed until Saturday (or maybe Sunday). Hopefully you can just retry and it'll work.

jakemas commented 3 months ago

Ahh okay! Looks like it’s still not opened (https://github.com/lamps-wg/dilithium-certificates/actions/runs/10018760275) but I will keep trying!

From: Sean Turner @.> Reply-To: lamps-wg/dilithium-certificates @.> Date: Monday, July 22, 2024 at 10:37 AM To: lamps-wg/dilithium-certificates @.> Cc: "Massimo, Jake" @.>, Mention @.***> Subject: Re: [lamps-wg/dilithium-certificates] Address #17 (PR #18)

The submission window was closed until Saturday (or maybe Sunday). Hopefully you can just retry and it'll work.

— Reply to this email directly, view it on GitHubhttps://github.com/lamps-wg/dilithium-certificates/pull/18#issuecomment-2243476045, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQHHONFCSHTNK6PNJOS4GP3ZNU7LBAVCNFSM6AAAAABKS4XDOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBTGQ3TMMBUGU. You are receiving this because you were mentioned.Message ID: @.***>

jakemas commented 3 months ago

Got it!

From: Sean Turner @.> Reply-To: lamps-wg/dilithium-certificates @.> Date: Monday, July 22, 2024 at 10:37 AM To: lamps-wg/dilithium-certificates @.> Cc: "Massimo, Jake" @.>, Mention @.***> Subject: Re: [lamps-wg/dilithium-certificates] Address #17 (PR #18)

The submission window was closed until Saturday (or maybe Sunday). Hopefully you can just retry and it'll work.

— Reply to this email directly, view it on GitHubhttps://github.com/lamps-wg/dilithium-certificates/pull/18#issuecomment-2243476045, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQHHONFCSHTNK6PNJOS4GP3ZNU7LBAVCNFSM6AAAAABKS4XDOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBTGQ3TMMBUGU. You are receiving this because you were mentioned.Message ID: @.***>