search

lamps-wg / dilithium-certificates

I-D that describes the algorithm identifiers for NIST's PQC ML-DSA for use in the Internet X.509 Public Key Infrastructure
Other
7 stars 7 forks source link

ML-DSA-44 or 65 example? #29

Closed csosto-pk closed 1 month ago

csosto-pk commented 1 month ago

The public key example looks to be from ML-DSA-65. The public key example looks to have an OID that ends in 65 and also 1.8KB size. So, it is ML-DSA-65, right @jakemas ?

Also, I am not sure what

These parameters MUST be encoded as a single OCTET STRING. is referring to. @jakemas

bwesterb commented 1 month ago

It's 44. See examples/generate.go, examples/*.pub, etc. Note that 1.8kB is the PEM encoded size and not the raw size.

jakemas commented 1 month ago

Shall we remove These parameters <bcp14>MUST</bcp14> be encoded as a single OCTET STRING.</t>

csosto-pk commented 1 month ago

Yes, I think we should remove

These parameters MUST be encoded as a single OCTET STRING.

bwesterb commented 1 month ago

This PR still incorrectly renames 44 -> 65.

csosto-pk commented 1 month ago

ACK. Removed the mistake of 44 --> 65. Only the removal of the "OCTET STRING" remains.

bwesterb commented 1 month ago

LGTM. (Can't add myself as reviewer.)