search

lamps-wg / dilithium-certificates

I-D that describes the algorithm identifiers for NIST's PQC ML-DSA for use in the Internet X.509 Public Key Infrastructure
Other
7 stars 7 forks source link

Preempt comment from Deb on repetitive text #52

Closed danvangeest closed 1 week ago

bwesterb commented 1 week ago

With this change, it suggests that we define that type here instead of citing the definition.

danvangeest commented 1 week ago

Line 191 says "NOTE: The above syntax is from {{!RFC5912}}..." although that is still not explicit without following the reference.

Line 191 could be changed to "... The above definition if from...", or line 179 could be changed to "The AlgorithmIdentifier type is defined in {{!RFC5912}} as follows:"

bwesterb commented 1 week ago

Perfect.

danvangeest commented 1 week ago

Perfect.

You didn't express a preference for either of the options I proposed so I picked one :)