lamps-wg / draft-composite-kem

IETF draft specifying PQC composite KEM algorithms for use in X.509 and CMS
Other
2 stars 1 forks source link

Comments from Stephen Ferrell #1

Closed ounsworth closed 7 months ago

ounsworth commented 1 year ago

(June 20, 2023)

A couple of specific comments in case those help:

the title refers to "Internet PKI" so I don't know if it
will in fact be possible to usefully unwind this from the
other composite drafts

[[MO]] We haven't changed the title since draft-ounsworth-pq-composite-sigs-00 in 2019. Happy to change that.

describing this as layering seems wrong

kema-CompositeKEM and the other ASN.1 structures seem very
complex and overly-generic
[[MO]] It's really just machinery to make the ASN.1 module shorter. Without it, the module would be many hundreds of lines longer. We can unroll it if that's the will of the WG.

PUBLIC-KEYS in table 1 refers to signatures, I didn't get
why?
[[MO]] copy&paste error. Thanks.

section 7.2 ("OR" modes) seems odd
[[MO]] OR modes are now covered by draft-pala-klaussner-composite-kofn; that section should have been removed.

appendix C confused me: this I-D has no IPR declaration
but states that an IPR declaration "relates" to this
draft
[[MO]] There's IPR on draft-ounsworth-pq-composite-sigs, which probably applies to all three drafts.