search

lamps-wg / draft-composite-kem

IETF draft specifying PQC composite KEM algorithms for use in X.509 and CMS
Other
2 stars 1 forks source link

Added a Use In CMS section #15

Closed ounsworth closed 4 months ago

ounsworth commented 5 months ago

Adding this section here avoids the need for a wrapper draft telling you how to use composite KEM in CMS.

Closes #12

ounsworth commented 5 months ago

Note-to-self: look at whether we need to specify higher levels of KDF and WRAP for the stronger algorithms -- see how DVG did it in the CMS-Kyber draft.

UPDATE: done.

ounsworth commented 5 months ago

Question: does the ## Certificate Conventions section collide with the recently-merged Key Usage section?

UPDATE: I think this is fine because this section is intended to be able to be standalone if LAMPS wants the alg definitions, and the "Use in CMS" to become separate documents.

ounsworth commented 5 months ago

We also need to add the SMIME-CAPS to the ASN.1 (find a good example doc).

ounsworth commented 4 months ago

Thanks for the review @danvangeest

Still TODO:

ounsworth commented 4 months ago

Review comments from Russ:

Mike:

You are using a mix of "wrap algorithm" and "key-encryption algorithm". CMS usually uses the later. Line 683 got it just right. That is, id-aes256-Wrap identifies a particular key-encryption algorithm. I am not sure the text at the top is aligned.

Line 663: I think you need o say how that happens. In some cases a different OID is used, but in others a different parameter value is used.

Line 675: make it clear thet it is the KEM.Encaps(pk). The function is specific to the KEM identified in 'kem'.

Line 681: Do any of your composite KEM algorithms REQUIRE a ukm? I can imagine a way to use DH and ECDH that require a UKM.

Russ