lamps-wg / draft-composite-kem

IETF draft specifying PQC composite KEM algorithms for use in X.509 and CMS
Other
6 stars 3 forks source link

Max suggests dropping SEQUENCE OF wrapper #68

Closed ounsworth closed 1 month ago

ounsworth commented 2 months ago

Hi Max,

If I understand your proposal, you are suggesting that

CompositeSignaturePublicKey ::= SEQUENCE SIZE (2) OF BIT STRING CompositeSignatureValue ::= SEQUENCE SIZE (2) OF BIT STRING

Becomes

CompositeSignaturePublicKey ::= BIT STRING CompositeSignatureValue ::= BIT STRING

An then you need to specify that for id-MLDSA44-RSA2048-PSS-SHA256 the first X bits are the ML-DSA-44 public key / signature, and the remaining Y bits are the RSA-2048.

The original reason for an ASN.1 wrapper was to gracefully handle algorithms with variable-length publickeys, signatures, or ciphertexts, which I believe there were some of in NIST Round 1. This is no longer a concern with FIPS 203 / 204, so we could now remove it. However, I think it will be a fair amount of editorial work (we will need to accurately list out the bit position to split at for each composite alg), and it is asking all existing composite implementations to change, then will require a lot of interop testing. Is this change really worth it?

If you feel strongly about this, then perhaps you could prepare the change to the document on a side-branch, and we could bring it to the LAMPS mailing list?

PiotrPopis commented 2 months ago

Since the current specifications indicate specific key lengths, concatenation instead of 2 sequences is an acceptable solution. However, I agree with Mike that the potential "gain" is not proportionate to the cost of changing the specifications, as well as the changes in the implementations currently being developed. My company has been implementing the structures in the "composite-sign" and "comosite-KEM" drafts for several months; we allow changes, but we do not support this one. Piotr Popis

ounsworth commented 1 month ago

Max withdrew the suggestion. Closing this issue.