lamtung16 / ML_ChangepointDetection

0 stars 0 forks source link

paper revisions #9

Closed tdhock closed 1 month ago

tdhock commented 3 months ago

before submitting https://arxiv.org/pdf/2408.00856 for peer review, please do the following.

add citation to https://deepcharles.github.io/files/TOV-EUSIPCO-17.pdf which is similar to your approach.

increase figure text size so it is about the same as caption text size. below is too small. image

below table text is also small. would be better if you could remove "mlp." to save space. image

below figure text too small image

below figure text too small image

below figure text too small image

below figure text is almost too small (OK for peer review, but would be better just slightly larger) image

lamtung16 commented 3 months ago

I updated the paper, when you have time, please take a look and give me some feedbacks Paper_ver2.pdf

tdhock commented 3 months ago

Fig 7 is better but axis text is still very small, and neighbors are too close together (for example 256 and 512) maybe fix by omitting every other text label: show only 128, 512 instead of 128, 256, 512. image

tdhock commented 3 months ago

new table 2 is good.

Fig 6 text size is good now but x axis text may be confusing to read, because some text 96, 99, 74, is very close to edge of panel. image

could be improved by adding horizontal space between panels.

tdhock commented 3 months ago

revised fig 3 is excellent, great work !

in new Fig 5 is looks like x/y axis title text is bigger which is good. but it looks like tick mark text is smaller which is bad. image please fix by increasing tick mark text.

lamtung16 commented 3 months ago

Here is my updates:

Please take a look: paper_ver2.pdf

tdhock commented 3 months ago

For Table 2 instead of writing "0" you could just leave the entry blank, which would provide greater visual emphasis between 0 and non-zero. new fig 7 looks great. New fig 6 looks great. new fig 5 looks great. overall great work, please re-read one last time and then submit for peer review.

lamtung16 commented 3 months ago

Ok will do, thank you for your help 🙂

On Sun, Aug 11, 2024, 10:48 AM Toby Dylan Hocking @.***> wrote:

For Table 2 instead of writing "0" you could just leave the entry blank, which would provide greater visual emphasis between 0 and non-zero. new fig 7 looks great. New fig 6 looks great. new fig 5 looks great. overall great work, please re-read one last time and then submit for peer review.

— Reply to this email directly, view it on GitHub https://github.com/lamtung16/ML_ChangepointDetection/issues/9#issuecomment-2282837379, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALFU4A6SJWN5EHVKPUA5UXDZQ6PXXAVCNFSM6AAAAABMGYCAH2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBSHAZTOMZXHE . You are receiving this because you commented.Message ID: @.***>

lamtung16 commented 2 months ago

I updated my paper and about to submit for peer review, can you take a look and give me some feedbacks paper_ver3.pdf

tdhock commented 2 months ago

looks good overall. Fig 4 is new right? i like it. please submit