lamuguo / re2

Automatically exported from code.google.com/p/re2
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Warnings (narrowing conversion) comipling under g++ 4.7.0 #63

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. g++ --version ==> g++ (GCC) 4.7.0
2. make test ==> warnings 

What is the expected output? What do you see instead?

re2/testing/re2_test.cc: In function ‘void re2::RE2FullMatchTypeTests()’:
re2/testing/re2_test.cc:751:43: warning: format ‘%lld’ expects argument of 
type ‘long long int’, but argument 4 has type ‘re2::int64 {aka long 
int}’ [-Wformat]
...
re2/testing/re2_test.cc:1001:3: warning: narrowing conversion of ‘172’ from 
‘int’ to ‘const char’ inside { } is ill-formed in C++11 [-Wnarrowing]

What version of the product are you using? On what operating system?

Please provide any additional information below.
NOTE: If you have a suggested patch, please see
http://code.google.com/p/re2/wiki/Contribute
for information about sending it in for review.  Thanks.

Original issue reported on code.google.com by michah.l...@gmail.com on 26 Apr 2012 at 3:25

GoogleCodeExporter commented 9 years ago
Looks like it just needs a fix that'll be similar to this pending code review:
http://codereview.appspot.com/5656095

Original comment by alex.pam...@gmail.com on 27 Apr 2012 at 3:34

GoogleCodeExporter commented 9 years ago

Original comment by rsc@golang.org on 10 Jan 2014 at 1:24