search

lamw / ghettoVCB

ghettoVCB
MIT License
1.28k stars 364 forks source link

Fix version detection for ESXi 7.0.x #247

Closed pmhausen closed 2 years ago

pmhausen commented 2 years ago

Hi William,

version detection broke again with the latest update to 7.0.3. I suggest using a wildcard match for 7.0.x as present in this pull request.

Kind regards, Patrick

pmhausen commented 2 years ago

Oh, and would you please consider participating in Hacktoberfest so my pull request counts? In case you accept it, of course.

TheNetworkIsDown commented 2 years ago

What is the purpose of the version check? I suppose it is there to prevent the software from suddenly erroring out after installing an incompatible release. Isn't whitelisting a large number of (future) releases like removing that check altogether? The correct approach would be for someone to actually test a new and not yet greenlit ESXi version and report back such that the verified version can be added. Everyone is obviously free to add it to their local script as well if it is very urgent, just as the tester would do.

lamw commented 2 years ago

Agreed @NotAProfessionalDeveloper

In fact, in early releases of ESX and ESXi, there were several breakages and I didn't want to assume the script will work simply because the prior version. Its possible we could see changes between even Update releases, although rare that would affect the backup script. For these reasons, I'd still error on the side of caution and ensuring folks can verify before updating the version.

For these reasons, I'll be closing this PR

pmhausen commented 2 years ago

I changed the code as requested in all three places.