search

lamw / ghettoVCB

ghettoVCB
MIT License
1.29k stars 365 forks source link

Added version 7.0.3 to script so it's compatible with latest version #248

Closed stickybyte closed 3 years ago

stickybyte commented 3 years ago

Tested and worked like a charm

pmhausen commented 3 years ago

I'd argue that my approach is more future proof ;)

https://github.com/lamw/ghettoVCB/pull/247

stickybyte commented 3 years ago

Indeed, this is just a quickfix that worked for me with no further impact

p-schneider commented 3 years ago

This is a quickfix but also incomplete, it calls the wrong command when using nfs shares and doens't work when restoring VMs. We can argue about allowing 7.0.x (wildcard) or just adding 7.0.3 (specific), but at least all 3 places should be changed to make it behave as expected. I personally would prefer the wildcard approach in #247, especially since that wildcard is not like 7.x.x but just 7.0.x

lamw commented 3 years ago

@stickybyte Could you address the feedback from @p-schneider mentioning this isn't complete fix regarding nfs shares?

stickybyte commented 3 years ago

@lamw Added the missing sutff now. It depends on you what you preffer. A wildcard or my hardcoded version number. Both will work ...

lamw commented 3 years ago

Resolved in #249

p-schneider commented 3 years ago

Thanks (Actually Resolved in #249)