use dot for fqdn in edge vm

lamw / vsphere-with-tanzu-nsxt-automated-lab-deployment

vSphere with Tanzu using NSX-T Automated Lab Deployment

212 stars 79 forks source link

Closed kikitux closed 4 years ago

kikitux commented 4 years ago

as today, edge name includes an @

so replacing with a dot, gets a proper fqdn, and with new changes, the script allows deploy more than 1 edge

thanks!

lamw commented 4 years ago

Doh! I can't believe I missed this. Thanks @kikitux for the catch. It looks like your PR had another change at the end, not sure why that is. I just pushed a fixed https://github.com/lamw/vghetto-vsphere-with-kubernetes-external-nsxt-automated-lab-deployment/commit/c4afc0e843518d286812d651a025f6e9e909c10b

kikitux commented 4 years ago

@lamw i think this solve the mistery on your past deployments being localhost

lamw commented 4 years ago

Indeed!