search

lamyj / odil

Odil is a C++11 library for the DICOM standard
Other
85 stars 21 forks source link

Throw a SocketClosed exception when the socket is closed. #47

Open cguebert opened 7 years ago

cguebert commented 7 years ago

There is currently no way to distinguish between the socket being closed and any exception occurring during message processing. As a temporary measure, I propose to send a SocketClosed exception that must be processed by the user application (as is the case with AssociationReleased and AssociationAborted). In the future, it can be interesting to rewrite parts of the StateMachine and the Transport classes to ensure correct transitions (and true asynchronous operations).

This is a possible solution to #39.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.04%) to 84.57% when pulling 28f009d1644f4503d3b1376818736401f0987c22 on cguebert:SocketClose into 225ddc37dd5804da3254ccd6eacee40832ed3196 on lamyj:master.