search

lamyj / odil

Odil is a C++11 library for the DICOM standard
Other
85 stars 21 forks source link

Added some python wrappers for odil #51

Closed edouard-mangel closed 7 years ago

edouard-mangel commented 7 years ago

Hi! I added some python wrappers, and also fixed some minor mistakes made while adding N-SET messages management.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 83.329% when pulling 4a3eaa8ef3fbabc88df40c9ef3c23a981d337be4 on fw4spl-org:master into 4de26c8984178a00d21e8dabc1bc5d2b02ef71f1 on lamyj:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 83.341% when pulling 8bf3b3088ee90708be6b2c728761eddb0b8a2854 on fw4spl-org:master into 4de26c8984178a00d21e8dabc1bc5d2b02ef71f1 on lamyj:master.

lamyj commented 7 years ago

The current PR looks OK but is a bit hard to process correctly as it mixes cosmetic changes (e.g. examples/store.cpp, src/odil/NSetSCP.cpp) and functional changes. Could you revert the style changes to leave only the functional changes?