Compilation of libodil on Windows (tested for VS 2015)

lamyj / odil

Odil is a C++11 library for the DICOM standard

Other

85 stars 21 forks source link

Compilation of libodil on Windows (tested for VS 2015) #8

Closed cguebert closed 8 years ago

cguebert commented 8 years ago

Modifications for CMake:

Finding all DCMTK libraries
Adding dependency to netapi32
Setting the correct version of _WIN32_WINNT
Grouping projects in the VS solution, and recreating the folders hierarchy for source files
Linking libodil as a shared library

Bug fixes:

Removed asking for a pointer in an empty vector (always crashes with VS).

Compilation fixes:

VS could not deduce the correct templates for the new element getters in DataSet. Instead of writing the correct template manually, rewrote the methods to be more concise.

coveralls commented 8 years ago

Coverage decreased (-0.01%) to 94.704% when pulling df425012a425831b9d9202fac43eb0fab97a6470 on cguebert:master into 0141c2eba4bb66cc5dc00c77256df53fefa46301 on lamyj:master.

lamyj commented 8 years ago

Welcome to Odil and thanks for the pull request! I added a few minor comments to your commits: could you make sure my suggestions don't mess up the Windows compilation (especially the one regarding not installing the examples). Once you confirm, I'll merge.

cguebert commented 8 years ago

It seems the automatic builds are failing, but I cannot see exactly why. My modifications of FindDCMTK maybe?

coveralls commented 8 years ago

Coverage decreased (-0.4%) to 94.36% when pulling 96d8f21fd18c629ce478514e8d925dfd4d6b6c01 on cguebert:master into 0141c2eba4bb66cc5dc00c77256df53fefa46301 on lamyj:master.

lamyj commented 8 years ago

Coveralls does not really complain (less than half a percent in coverage change is not going to bother me), and Appveyor complains because my appveyor.yml file is broken: as long as Travis is happy, I'll merge.

Thanks!