search

lamyj / odil

Odil is a C++11 library for the DICOM standard
Other
85 stars 21 forks source link

LGTM.com recommendation: Unused local variable #87

Closed DimitriPapadopoulos closed 2 years ago

DimitriPapadopoulos commented 3 years ago

Follow-up of 4e75ef7.

DimitriPapadopoulos commented 3 years ago

I had a look at the C++ source code and get_negotiated_parameters() does not seem to be modifying the association: https://github.com/lamyj/odil/blob/dc8d063d8ecf1fa787a3e2de7f5b9a9574fa1105/src/odil/Association.cpp#L160-L165

The negotiated parameters are already set in the associate() method: https://github.com/lamyj/odil/blob/dc8d063d8ecf1fa787a3e2de7f5b9a9574fa1105/src/odil/Association.cpp#L236-L237