Update Writer class to support OD, OL and OV value representations

lamyj / odil

Odil is a C++11 library for the DICOM standard

Other

85 stars 21 forks source link

Update Writer class to support OD, OL and OV value representations #94

Closed ClementTroesch closed 5 months ago

ClementTroesch commented 5 months ago

Hi there,

This is a small PR to support OD, OL and OV value representations in the Writer class.

Thanks, Clément

lamyj commented 5 months ago

Great! I just have a small concern regarding the DCMTK part: do you know when these VRs were added to DCMTK ? i.e. does it require a bleeding edge version, or is the version of Debian Sid (3.6.7) sufficient ?

ClementTroesch commented 5 months ago

I have tested it with release 3.6.7 and it works well.

It looks like:

OD has been added 11 years ago (See dcvrod.h)
OL has been added 9 years ago (See dcvrol.h)
OV has been added 5 years ago (See dcvrov.h)

Clément

lamyj commented 5 months ago

Merged, thanks!