lananh03 / getWeather

Creative Commons Zero v1.0 Universal
0 stars 0 forks source link

[ENH] Use las2peer service properties #2

Closed pdolif closed 4 years ago

pdolif commented 4 years ago
  1. Motivation - It would be nice to use service properties offered by las2peer for the app id of openweathermap.
  2. Specification
    • Add property to properties file
    • Add property to main class
    • Use property in API call
  3. Finalised state - System should use service properties for the openweathermap app id.
pdolif commented 4 years ago

The commit https://github.com/lananh03/getWeather/commit/7035b08e7b6a2db1188cae0192dc2110b5520b95 and the following ones solve this issue.

lananh03 commented 4 years ago

html file https://github.com/lananh03/getWeather/commit/4cca33f827ecdcb090a7d188c2fb6c0ed12084d1

lananh03 commented 4 years ago

html file https://github.com/lananh03/getWeather/commit/4cca33f827ecdcb090a7d188c2fb6c0ed12084d1