search

lancachenet / lancache-dns

DNS Docker service for a lancache.
https://hub.docker.com/r/lancachenet/lancache-dns/
MIT License
280 stars 73 forks source link

refactor: replace bash script with dnstool for config generation #126

Open nightah opened 2 years ago

nightah commented 2 years ago

This PR replaces the bash script utilised for config generation with a static tool.

The tool replicates the existing bash script with some additional logic like validating IP addresses, ensuring they're private where the LANCache stack expects them to be private.

This change is also a precursor to allowing us to easily add IPv6 support.

stale[bot] commented 2 years ago

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

nightah commented 2 years ago

@VibroAxe ping should we also move the dnstool repo under this the lancachenet org?

VibroAxe commented 2 years ago

Almost definitely. This is on my Christmas list to have a play with 🧐

stale[bot] commented 2 years ago

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

VibroAxe commented 2 years ago

Bad bot (and bad me)

VibroAxe commented 2 years ago

@nightah finally got around to looking at this, yes I know I suck! Any thoughts on the above?

JasonRivers commented 2 years ago

I don't see this being a problem as long as it works - I'm not in a position to test at the moment, However, I would like to see at least basic README in the dnstool repo on what it is and how it should be run. Repos with no readme in formation at all bother me a little!

stale[bot] commented 2 years ago

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 2 years ago

This issue has been automatically closed after being inactive for 30 days. If you require further assistance please reopen the issue with more details or talk to us on discord

VibroAxe commented 2 years ago

Bad bot, bad vibs.

This is ready for merging just needs an agreement on where to put the thing!

nightah commented 2 years ago

I think if we can agree on the scope of the tool it'll make the where to put it easy. If we're going to keep it just for the DNS management element and the addition of IPv6 then the current name is probably fine, I can transfer the repo to the lancachenet organisation and that solves where to put it.

If we have another idea in terms of additional scope that this might take on in future then let's agree on what that should be and name it accordingly.