search

lancachenet / lancache-dns

DNS Docker service for a lancache.
https://hub.docker.com/r/lancachenet/lancache-dns/
MIT License
280 stars 73 forks source link

WIP: Added ipv6 support #97

Open pamidur opened 4 years ago

pamidur commented 4 years ago

With these changes startup script can create AAAA records Also prevent querying upstream servers when resolution is done from cache.

VibroAxe commented 4 years ago

We've only had issues with ipv6 so far, DNS is only part of the issue. Currently it's disabled for good reasons.

If this is fully tested with sniproxy and monolithic ipv6 then that might be a different discussion

pamidur commented 4 years ago

Well, I currently use it with lancachenet (ipv6 modified) in my ipv6 only network though without sniproxy. I'm not ready (yet) to make a PR for lancachenet itself.

However I believe that there might more than one use case for lancache-dns. And I believe it should not be tied to lancachenet this hard.

astrolox commented 4 years ago

Perhaps a enable/disable flag would be a good enough addition to allay any concerns?

pamidur commented 4 years ago

@astrolox basically it works the same way as before if you supply only ipv4 addresses. Now it just supports ipv6 addresses and dns records as well.

astrolox commented 4 years ago

I'm a huge fan of IPv6 and I love that you're contributing this. Yet I'm not ready to commit this without further testing and spending some time to understand what issues have arisen in the past. I'll leave this open for now and hopefully we can circle back to it when we have some spare time in the future.

VibroAxe commented 4 years ago

Sorry @pamidur, I didn't intend to come accross negatively!

I'm also a big fan of ipv6 but we've been caught out numerous times with people not understanding it enough causing huge issues. Currently the DNS disabling ipv6 lookups has been a useful backstop against "my setup is broken" issues.

I agree with astro, I'm interested in this, and we'll definitely keep it open. However I wouldn't be happy to release this without the corresponding generic/monolithic update. If you can submit a WIP PR to the relevant project then we can discuss the route to testing and adoption

pamidur commented 4 years ago

@VibroAxe , @astrolox , Alright, I'll try to put everything together and make a PR for ipv6 for lancache-generic soon