search

lancachenet / monolithic

A monolithic lancache service capable of caching all CDNs in a single instance
https://hub.docker.com/r/lancachenet/monolithic
Other
726 stars 73 forks source link

Add a health check to the Dockerfile #140

Closed egguy closed 1 year ago

egguy commented 2 years ago

Allow to detect it there's problem with the nginx process and restart it. Use the /lancache-heartbeat URL to check.

Based on: https://scoutapm.com/blog/how-to-use-docker-healthcheck

stale[bot] commented 2 years ago

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

VibroAxe commented 2 years ago

@egguy Sorry for the delay in this, it's been a pretty hectic time. Nice idea, see comment on the review, i'd love to implement this

egguy commented 2 years ago

I've updated the pull with your recommendations.

stale[bot] commented 2 years ago

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 2 years ago

This issue has been automatically closed after being inactive for 30 days. If you require further assistance please reopen the issue with more details or talk to us on discord

egguy commented 2 years ago

Hello @VibroAxe, I hope it's not tool late, could I request a review, or there are some remaining changes to do ?

VibroAxe commented 2 years ago

Hey, certainly. Apologies but code review has taken a bit of a back seat. I'll take a look

egguy commented 2 years ago

No worries, It was my bad too, I was too late to react to prevent closure from the bot.

Thx for taking time and maintaining this project

PS: Is it possible to also take a look ad #147 to allow the test to work again ?

stale[bot] commented 1 year ago

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 year ago

This issue has been automatically closed after being inactive for 30 days. If you require further assistance please reopen the issue with more details or talk to us on discord

PotcFdk commented 1 year ago

@VibroAxe is there a reason why Pull Requests keep getting auto-closed by the bot? I see how there could be a valid reason for issues, but IMO PRs can just stay open until a developer/maintainer decides it doesn't make sense to pursue them further. Autoclosing them because "hurr durr it's inactive" even though what's missing can't even be delivered by the author of the PR is a bit irritating.

VibroAxe commented 1 year ago

Fair comment. I'll see if I can stop the bot idling out on PRs

stale[bot] commented 1 year ago

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

PotcFdk commented 1 year ago

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

bump

stale[bot] commented 1 year ago

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

jobhh commented 1 year ago

Any progress on not idling out on PRs? :p

stale[bot] commented 1 year ago

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 year ago

This issue has been automatically closed after being inactive for 30 days. If you require further assistance please reopen the issue with more details or talk to us on discord

PotcFdk commented 1 year ago

Can this be reopened?