search

lancachenet / monolithic

A monolithic lancache service capable of caching all CDNs in a single instance
https://hub.docker.com/r/lancachenet/monolithic
Other
725 stars 73 forks source link

Using the existing CACHE_DOMAINS_BRANCH and CACHE_DOMAINS_REPO Variable #166

Closed b-reich closed 1 year ago

b-reich commented 1 year ago

Using the allready existing Variables.

Maybe this would be need as a feature for the runtime.

VibroAxe commented 1 year ago

This RUN line is only run once during the docker build steps, so the ENV vars will only ever be the defaults. Not sure this gains us anything?

The single branch change might make some sense though?

b-reich commented 1 year ago

Its not a big benefit thats true. The variables were already there. Pulling a fresh list of Domains at start time or periodically, would be a nice improvement I think.

VibroAxe commented 1 year ago

Its not a big benefit thats true. The variables were already there. Pulling a fresh list of Domains at start time or periodically, would be a nice improvement I think.

This is exactly what is already done, each time monolithic starts up it will pull the latest cache-domains from repo. It's handled here https://github.com/lancachenet/monolithic/blob/a45516468d9dd5dd7b96cdf311c07adb472c4e7f/overlay/hooks/entrypoint-pre.d/15_generate_maps.sh#L17

b-reich commented 1 year ago

Ahh okay. Thank you for the clarification.

Using the variables in the Dockerfile is still usefull I think. But its not a big deal to changes the values in 2 spots in the same file.

stale[bot] commented 1 year ago

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 year ago

This issue has been automatically closed after being inactive for 30 days. If you require further assistance please reopen the issue with more details or talk to us on discord