search

lancaster-university / codal-core

MIT License
11 stars 28 forks source link

Remove outdated JACDAC abstraction #127

Closed jamesadevine closed 3 years ago

jamesadevine commented 3 years ago

This PR removes all outdated JACDAC code from codal-core. Please visit the https://aka.ms/jacdac website or any of our many repositories microsoft/jacdac microsoft/jacdac-ts and microsoft/jacdac-c to discover the new home for JACDAC.

jamesadevine commented 3 years ago

In addition to this pull request, I have made PRs to the following:

I believe this should cover the entirety of CODAL. I've built each of the above targets too (including microbit-v2) to ensure my changes are good. Is there anything I've missed @mmoskal @finneyj?

When merged, this PR will close lancaster-university/codal-core#125 and microsoft/jacdac#64

mmoskal commented 3 years ago

Sounds good!

finneyj commented 3 years ago

Thanks @jamesadevine - makes sense. No point having old versions lying around when we have up to date TypeScript and Python implementations.

Would welcome any new jacdac goodies in codal in the future of course!

jamesadevine commented 3 years ago

Thanks @finneyj :smile: watch out for future PRs!