search

lancaster-university / codal-core

MIT License
12 stars 27 forks source link

Add JDEvent type instead Event #36

Closed pelikhan closed 5 years ago

pelikhan commented 5 years ago

The Event has a 64bit timestamp that also gets sent over the network. Can we use a dedicated struct here? https://github.com/lancaster-university/codal-core/blob/3f1a2e43c226eb73df75306e6629eadd9d365662/source/JACDAC/JDMessageBusDriver.cpp#L129

jamesadevine commented 5 years ago

The remainder of the packet is filled with noise regardless, why reduce data resolution by removing the timestamp?

I'm more than happy to introduce a struct although it doesn't seem necessary to me given that we have the Event struct already.

pelikhan commented 5 years ago

It would be easier for maintenance/modularity to have a JDEvent struct.