search

lancaster-university / codal-core

MIT License
12 stars 27 forks source link

Add function to list all drivers in protocol (jacdac) #49

Closed pelikhan closed 5 years ago

pelikhan commented 5 years ago

I need to send the entire state of each driver "device" to MakeCode side to create a debugger UI. Can you add a function to JDProtocol to list drivers?

jamesadevine commented 5 years ago

Does this mean you just want a pointer to the driver array?

pelikhan commented 5 years ago

Pretty much make it public.

Get Outlook for iOShttps://aka.ms/o0ukef

From: James Devine notifications@github.com Sent: Friday, November 30, 2018 9:26 AM To: lancaster-university/codal-core Cc: Peli de Halleux; Author Subject: Re: [lancaster-university/codal-core] Add function to list all drivers in protocol (jacdac) (#49)

Does this mean you just want a pointer to the driver array?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flancaster-university%2Fcodal-core%2Fissues%2F49%23issuecomment-443276900&data=02%7C01%7Cjhalleux%40microsoft.com%7Ceab30363a96f45b09f4808d656e8e4eb%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636791955603895563&sdata=hECp7C1YXbhwUKJpNIPtj6k2r%2BuMXXDgH5%2BK3RlRNQA%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KfpZxODO0ANqRtnXhDl2QgWNTaqdks5u0WomgaJpZM4Y7_lX&data=02%7C01%7Cjhalleux%40microsoft.com%7Ceab30363a96f45b09f4808d656e8e4eb%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636791955603905571&sdata=P6QZoz3I%2Ba%2FyHd%2Flg43i9v81mUKOf1z196d0LGdahvQ%3D&reserved=0.

jamesadevine commented 5 years ago

I'm not sure you can be trusted... :wink:

Yup, will do!

pelikhan commented 5 years ago

Also need access to the device field.

Get Outlook for iOShttps://aka.ms/o0ukef

From: James Devine notifications@github.com Sent: Friday, November 30, 2018 9:39 AM To: lancaster-university/codal-core Cc: Peli de Halleux; Author Subject: Re: [lancaster-university/codal-core] Add function to list all drivers in protocol (jacdac) (#49)

I'm not sure you can be trusted... 😉

Yup, will do!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flancaster-university%2Fcodal-core%2Fissues%2F49%23issuecomment-443280790&data=02%7C01%7Cjhalleux%40microsoft.com%7Cb36b328cff004418c82408d656eab5be%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636791963403557648&sdata=LmnB2qWBsYRdQBYZApNStmi06HrWNrkIf8Dx1%2FqaJhU%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4Ka42RluI_rFBiHlCuDIOmDT8B-Nrks5u0W0ygaJpZM4Y7_lX&data=02%7C01%7Cjhalleux%40microsoft.com%7Cb36b328cff004418c82408d656eab5be%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636791963403567661&sdata=yQ%2BJ9FTTySTqbY%2Bjv6IrAIrhV9VvoThva0HjwQLvA5k%3D&reserved=0.

jamesadevine commented 5 years ago

Will add an accessor for that.

jamesadevine commented 5 years ago

JDProtocol::drivers is now public.

Each driver now has a getState member function.