lancaster-university / codal-core

MIT License
12 stars 27 forks source link

JacDacMessage enumeration types should match #53

Closed teddyseyed closed 5 years ago

teddyseyed commented 5 years ago

When creating jacdac messages, occasionally you will have scenarios where the value of a jacdac message on one device will not have the same jacdac message value on another device. This will affect how the listener will work on either side.

For example:

Device 1 can have

enum JacDacMessage { message1, SHAKE1, SHAKE2, SHAKE3 }

and Device 2 can have

enum JacDacMessage { SHAKE1, }

pelikhan commented 5 years ago

This is a MakeCode issue. JacDac is not aware of the way we encode messages.

jamesadevine commented 5 years ago

Hiya @teddyseyed

You should ideally be running the same driver with the same enumeration on either side of the link. :smile: