Use pointer for LED so that NULL can be passed in. - Githubissues

lancaster-university / codal-core

MIT License

11 stars 28 forks source link

Use pointer for LED so that NULL can be passed in. #57

Closed pelikhan closed 5 years ago

pelikhan commented 5 years ago

https://github.com/lancaster-university/codal-core/blob/839e9bcf745b58a03b02ed497b1ac6791c82149d/inc/JACDAC/JACDAC.h#L181

jamesadevine commented 5 years ago

You have two constructors?

https://github.com/lancaster-university/codal-core/blob/839e9bcf745b58a03b02ed497b1ac6791c82149d/inc/JACDAC/JACDAC.h#L170

pelikhan commented 5 years ago

LookupPin is a runtime API so that I cannot pick the correct ctor at compile time.

pelikhan commented 5 years ago

Similar issue with the bridge... Can't unset the bridge once it is in.

jamesadevine commented 5 years ago

ACK!

jamesadevine commented 5 years ago

Done.