search

lancaster-university / codal-core

MIT License
11 stars 28 forks source link

Support for Enter/delete keys in keyboard #93

Open pelikhan opened 5 years ago

pelikhan commented 5 years ago

See https://github.com/Microsoft/pxt-adafruit/issues/932

jamesadevine commented 5 years ago

These are already supported:

https://github.com/lancaster-university/codal-core/blob/master/source/drivers/AsciiKeyMap.cpp#L7

Use:

https://github.com/lancaster-university/codal-core/blob/master/source/drivers/HIDKeyboard.cpp#L495

pelikhan commented 5 years ago

Can we add those in keymap? I use the FunctionKey/MediaKey stuff in MakeCode.

jamesadevine commented 5 years ago

Adding them to the keymap wouldn't be very useful, but return, and backspace could be added to the interface...

Are there any other keys we need to consider?

pelikhan commented 5 years ago

Those are the 2 requested by Adafruit users.

Get Outlook for iOShttps://aka.ms/o0ukef

From: James Devine notifications@github.com Sent: Thursday, March 7, 2019 11:32:54 AM To: lancaster-university/codal-core Cc: Peli de Halleux; Author Subject: Re: [lancaster-university/codal-core] Support for Enter/delete keys in keyboard (#93)

Adding them to the keymap wouldn't be very useful, but return, and backspace could be added to the interface...

Are there any other keys we need to consider?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flancaster-university%2Fcodal-core%2Fissues%2F93%23issuecomment-470662883&data=02%7C01%7Cjhalleux%40microsoft.com%7Cbe771a5687e445e2152208d6a333b26f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636875839761473757&sdata=H5%2BRnHtBAedm7BetBecIaqpUi9f6UwG8defeGB%2FJK9M%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KV202CGKSXrSTN136vcZqI-epcGcks5vUWlmgaJpZM4bj3HR&data=02%7C01%7Cjhalleux%40microsoft.com%7Cbe771a5687e445e2152208d6a333b26f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636875839761473757&sdata=u9RlsIm0Vzcni5rhpuLtrzwYK4xzpNNL2r7xLM43QFg%3D&reserved=0.

pelikhan commented 5 years ago

Can we add them to the function key enum? https://github.com/Microsoft/pxt-common-packages/blob/master/libs/keyboard/keyboard.cpp#L41 I don't see how I would support those otherwise.

pelikhan commented 5 years ago

Maybe add backspace and tab also? Those are the only ones other than enter/return I see as missing.

jedgarpark commented 3 years ago

Just got a new request for Enter key in the makecode.adafruit.com, could that be added to the GUI? It seems to exist in maker.makecode.com.

pelikhan commented 3 years ago

@jamesadevine

jamesadevine commented 3 years ago

@pelikhan If this is in maker, shouldn't the code in maker be ported to adafruit?

jedgarpark commented 3 years ago

I don't know how that mechanism works, but they are different enum lists currently when I load them up: mmc_enter mca_noenter