search

lancaster-university / codal-core

MIT License
11 stars 28 forks source link

Document JACDAC panic codes #97

Open pelikhan opened 5 years ago

pelikhan commented 5 years ago

This panic code overlaps with MakeCode 909 code. Could you define all error codes used by JACDAC? https://github.com/lancaster-university/codal-core/blob/e75d75647c3a6c6cfe0fe0f76baf73b8ad9fb8fe/source/JACDAC/JACDAC.cpp#L14

jamesadevine commented 5 years ago

That's a generic assert in CODAL, not JACDAC. I need to remove all of the random asserts across the codebase. Should be defined in a header file somewhere.

pelikhan commented 5 years ago

It actually looks like dead code in that file.

jamesadevine commented 5 years ago

grep across the code base, there isn't a unified definition of CODAL_ASSERT. I was looking at fixing this up a few weeks ago.