Fixed sensor value. - Githubissues

lancaster-university / codal-mbedos

1 stars 5 forks source link

Fixed sensor value. #7

Closed greg-norris closed 6 years ago

greg-norris commented 6 years ago

Corrects the values we get from the sensor.

jamesadevine commented 6 years ago

Hi @greg-norris,

I'm not going to merge this PR, as your fix applies to all mbed os targets, of which the brainpad is just one. By modifying this file, all future mbedos devices (i'm adding one today) will be affected.

A better fix is to simply address the code paths in mbed-os and submit the recompiled files, see #6.

Sorry for being difficult 😅

jamesadevine commented 6 years ago

@greg-norris an alternate, equally acceptable fix, is to subclass MbedPin and apply your patch. If you make that patch and submit the PR to https://github.com/lancaster-university/codal-brainpad , I would gladly accept that.