search

lancaster-university / codal-microbit-v2

CODAL target for the micro:bit v2.x series of devices
MIT License
43 stars 52 forks source link

Make the Sound Expressions effect default parameters/steps CODAL defaults #315

Closed microbit-carlos closed 5 months ago

microbit-carlos commented 1 year ago

Neither MakeCode nor MicroPython expose to the users a way to change the fx params and steps. For consistency we should use the same values for both platforms, to be able to generate the same sounds. In that case it makes sense to make these the default values inside CODAL instead of having both platform setting the same values.

https://github.com/microsoft/pxt/blob/5e2ff19c7d44bc659b997530c96b7ac9ad6a6551/webapp/src/components/soundEffectEditor/soundUtil.ts#L24-L42

martinwork commented 8 months ago

Reported as a Python problem in support ticket https://support.microbit.org/helpdesk/tickets/70448 (private)

microbit-carlos commented 5 months ago

@JohnVidler the preferred MicroPython solution is to set the parameters as #defines and MicroPython can use those:

JohnVidler commented 5 months ago

I've defined a few SFX defaults over in this PR, would this do the trick?

https://github.com/lancaster-university/codal-microbit-v2/pull/417

microbit-carlos commented 5 months ago

PR has been merged, next steps is to check that MicroPython is implementing it and submitting a PR to MakeCode.

microbit-carlos commented 5 months ago

MicroPython work tracked in:

MakeCode in:

This CODAL issue can be closed as complete.