Closed martinwork closed 1 year ago
I think make it really fast if triple_reset
?
https://github.com/lancaster-university/codal-microbit-v2/blob/master/model/MicroBit.cpp#L254C19-L254C19
I'd say drop this to 40ms in the A+B case in 10ms in the case of triple_reset
?
@martinwork is there a PR for this issue created already? We had the recollection of something maybe being prepared, but couldn't find it.
@microbit-carlos My recollection is that @jaustin asked me to create an issue, not a PR.
Oh right, thanks for clarifying. Talking with Jonny, we definitely want to start working on this, would you be able to implement it?
@microbit-carlos PR https://github.com/lancaster-university/codal-microbit-v2/pull/368
Thanks Martin! I guess for consistency we should reduce the V1 DAL delay to 40ms as well, could you raise that PR too? Thanks!
@microbit-carlos I have updated PR https://github.com/lancaster-university/codal-microbit-v2/pull/368 with a 20ms delay as discussed. I'll create a V1 DAL PR . also with a 20ms delay.
PR https://github.com/lancaster-university/codal-microbit-v2/pull/368 has been merged and this can be closed as resolved 🎉
The V1 DAL equivalent task is captured in:
The delay while the screen is filled is only necessary for A+B+RESET, to check A and B are held.
https://github.com/lancaster-university/codal-microbit-v2/blob/master/model/MicroBit.cpp#L251
@jaustin Bypass the screen fill, or just speed it up?