search

lancaster-university / codal-microbit-v2

CODAL target for the micro:bit v2.x series of devices
MIT License
41 stars 50 forks source link

CI: Update size diff workflow to let you configure the samples commit. #358

Closed microbit-carlos closed 11 months ago

microbit-carlos commented 11 months ago

New additions to the samples repo that use newer APIs will cause build failures in the "size diff" workflow, as it might be configured to compile an older versions of CODAL without those APIs. This is currently the case, as new asserts have been added to CODAL and the samples repo, so any comparison with older CODAL tags will fail.

So, this PR adds another entry to the form to optionally specify a samples repo commit (bottom one in this screenshot):

image
microbit-carlos commented 11 months ago

To test this, I triggered a workflow with the form comparings tags v0.2.40 vs 0.2.57, using an older version of microbit-v2-samples: https://github.com/lancaster-university/codal-microbit-v2/actions/runs/5715279405

And it all works well, so I'll merge this 👍