search

lancaster-university / codal-microbit-v2

CODAL target for the micro:bit v2.x series of devices
MIT License
43 stars 52 forks source link

BLE: Simplify device name string creation. #371

Closed microbit-carlos closed 1 year ago

microbit-carlos commented 1 year ago

Saw this when looking at https://github.com/lancaster-university/codal-microbit-v2/issues/370, it's a small change that results in the same string, but it saves a bit of flash with gcc v10.3.

The bloatly CI workflow should post here the size diff.

The modelVersion instance is not used anywhere else, disName results in the same string and is not used anywhere else either.

github-actions[bot] commented 1 year ago

Build diff

Base commit: fbe41c4933f90134fc20c32049fa6b2b0637df60 Action run: https://github.com/lancaster-university/codal-microbit-v2/actions/runs/6084596139

     VM SIZE    
 -------------- 
  -0.0%      -2    [section .text]
  -0.8%     -34    /home/runner/work/codal-microbit-v2/codal-microbit-v2/libraries/codal-microbit-v2/source/bluetooth/MicroBitBLEManager.cpp
  -0.0%     -36    TOTAL
JohnVidler commented 1 year ago

Looks good to me, lets get this merged in.