search

lancaster-university / codal-microbit-v2

CODAL target for the micro:bit v2.x series of devices
MIT License
41 stars 50 forks source link

Radio feature request: Configurable `MICROBIT_RADIO_MAX_PACKET_SIZE` #384

Closed microbit-carlos closed 7 months ago

microbit-carlos commented 8 months ago

To be able to send packets larger than 32 bytes: https://github.com/lancaster-university/codal-microbit-v2/blob/348afc4c2de5c602b40b79ae63c377909404c96f/inc/MicroBitRadio.h#L74

This has been possible in MicroPython since V1 and, to my knowledge, never had any issues. Of course, MicroPython has their own radio driver implementation, but a quick test changing the value manually seems fine.

Although in V1 there was a report of some possible issues:

martinwork commented 8 months ago

I think the configuration allows 8 bits for the length. https://github.com/lancaster-university/codal-microbit-v2/blob/master/source/MicroBitRadio.cpp#L334 https://infocenter.nordicsemi.com/index.jsp?topic=%2Fps_nrf52833%2Fradio.html&cp=5_1_0_5_17_14_51&anchor=register.PCNF0

microbit-carlos commented 8 months ago

Yeah, for MicroPython the max length is 255 - header size. Since CODAL is using 3 bytes of header I think the max size could be 252 bytes.