search

lancaster-university / codal-nrf52

MIT License
3 stars 15 forks source link

Fixed typo in NRF52Serial::setBaudrate(). & Added newline at EOF. #10

Closed OpusK closed 4 years ago

OpusK commented 4 years ago

I fixed a misuse of local variables and parameter names in function NRF52Serial::setBaudrate(). This modification allows you to change the baudrate of the serial normally.

And, I added a newline at the end of the file to ensure normal file comparisons between different systems.

mmoskal commented 4 years ago

Thanks!

jamesadevine commented 4 years ago

Thanks for the contribution @OpusK !

Just to make you aware, this is an implementation that is intended to provide a basic debug channel using printf. Expect it not to work with the higher level abstraction (i.e. send, read) at the moment.

OpusK commented 4 years ago

Hi, @jamesadevine

You are right. The behavior of codal::Serial does not seem to match the nordic behavior of UARTE(DMA) library. So it's tricky to implement.