Feature saadc - Githubissues

lancaster-university / codal-nrf52

MIT License

3 stars 15 forks source link

Feature saadc #15

Closed ajtwlsdlqp closed 1 year ago

ajtwlsdlqp commented 4 years ago

Add I2S in peripheral_alloc.
Add NRF52Pin saadc

finneyj commented 4 years ago

Awesome - thanks @ajtwlsdlqp!

I'm working on a DMA streaming branch for the SAADC too, but I haven't implemented these interfaces yet...

Rather than two independent implementations, would it be ok if I merge your contribution into that, so we can have a unified implementation?

microbit-carlos commented 1 year ago

Thank you for the PR @ajtwlsdlqp! We've implemented ADC in parallel and I believe this feature is already present in the code base, so this change is no longer required. Sorry we didn't get a chance to merge this around that time, and thanks for your time and effort!