search

lancaster-university / codal-nrf52

MIT License
3 stars 15 forks source link

[Clang Compatibility] Patch to define the .heap section as allocatable. #51

Closed Johnn333 closed 1 year ago

Johnn333 commented 1 year ago

An SDK_mods like approach to solving the issue of needing to change nrfx files when we aren't easily able to update the sub-module. Note: The current patch will also apply when building with GCC, from testing this seems be fine in both cases.

JohnVidler commented 1 year ago

Merging this to keep development rolling.

Note that in general we should avoid using this override behaviour where possible, as the maintenance overheads on us increase with each overriden file. In this case this is on a file that is unlikely to change upstream, so its mostly ok.

Johnn333 commented 1 year ago

Probably worth documenting somewhere that we cannot update nrfx to a higher version whilst using the current SDK: https://github.com/NordicSemiconductor/nrfx/issues/73. Some work will have to be done here to reach the ideal solution of removing this method of applying a patch.