search

lancaster-university / codal-nrf52

MIT License
3 stars 15 forks source link

use same packet size as microbit to match CRC #8

Closed pelikhan closed 4 years ago

pelikhan commented 4 years ago

Required to have a nrf52 talk to micro:bit.

jamesadevine commented 4 years ago

I'm happy to merge if the reason is alignment with the micro:bit interface.

I would have thought that the maximum packet size would have no bearing on the calculation of the CRC. It should only calculate up to and including LENGTH bytes.

pelikhan commented 4 years ago

32 is part of the “spec” by now.

jamesadevine commented 4 years ago

Yup agree, but it seems like you're also reporting a bug? Are you saying the radios are incompatible with different max packet sizes?

pelikhan commented 4 years ago

Be happy and merge

jamesadevine commented 4 years ago

Hahaha :smile:

pelikhan commented 4 years ago

They are incompatible with different sizes. Regardless if we have some bug, the Nrf51 would not be able to read 40bytes packets.