search

lancaster-university / microbit-dal

http://lancaster-university.github.io/microbit-docs
Other
259 stars 131 forks source link

Pairing with Google Pixel fails #254

Closed ghost closed 7 years ago

ghost commented 7 years ago

Per the subject, pairing with the new Google Pixel always fails. See video demo of the problem here:

https://www.youtube.com/watch?v=VrFWLcpe_-4&feature=youtu.be

With assistance from Nordic support, this has been tracked down to the fact that the micro:bit disconnects abruptly, as soon as pairing has completed. This should not cause a problem but for some reason the Pixel seems to think the pairing process has not completed and so clears the keys relating to the micro:bit. The android bluetooth HCI snoop log shows that the controller sends a disconnect message to the host, telling it the remote device disconnected. Not long after, the host sends a command to the controller that it should delete the link keys for the microbit device.

hci_log_delete

Commenting out the disconnect call here:

https://github.com/lancaster-university/microbit-dal/blob/master/source/bluetooth/MicroBitBLEManager.cpp#L493

"Solves" the problem i.e. pairing completes OK with no error.

Is this abrupt disconnect necessary? Obviously disconnection will occur when the micro:bit resets.

finneyj commented 7 years ago

thanks @bluetooth-mdw.

I seem to recall the disconnection is there to enable the storage of CCCDs. We should check, but i'm pretty sure that it's essential to store CCCD state for iOS devices before the micro:bit resets out of pairing mode. Storing the CCCD only proved possible during a disconnected state, hence the force disconnect...

Based on code inspection, it looks like the disconnect is issued very quickly after pairing (to ensur eit happens before a user resets the micro:bit)... maybe simply waiting a little longer would suffice here? Is there an indication from the logs how long a delay is expected by the Pixel before a disconnect would be deemed ok?

ghost commented 7 years ago

Nordic just recreated the issue on one of their dev boards and confirm a delay before disconnecting seems to resolve it. I'll try this (though I'm pretty sure I already did!) and let you know how it goes.

ghost commented 7 years ago

PR submitted. Tested with Pixel. Does the job :-)

Kudos to Nordic for helping figure this out.

https://github.com/lancaster-university/microbit-dal/pull/255

ghost commented 7 years ago

I just encountered what looks like the same problem with my Nexus 9 tablet with a hex file created a couple of months ago on a micro:bit. I'm beginning to think the issue may be with Android 7.1.1 which is what my Nexus is now running and what the Pixel is running too.

@pelikhan heads up as if I'm right we'll see this issue more often. Might be as well to get my fix into PXT soon.

pelikhan commented 7 years ago

@finneyj is there a tag with the fix?

whaleygeek commented 7 years ago

Anyone got a progress update on this one, as to when it might surface to live? Thanks!

DavidWhaleIET commented 7 years ago

Has this fix been deployed yet does anyone know, @finneyj @jaustin

finneyj commented 7 years ago

@DavidWhaleIET afraid this is blocked on me David - my bad. I'll get a release out this week for sure including all the BLE updates and PWM fix.

Unless anyone knows where I can get a machine to make a hoard of mini-me clones? maybe one at CES?

whaleygeek commented 7 years ago

No problem. If we could tag this against a specific release future, I could monitor this myself without bugging you :)

DavidWhaleMEF commented 7 years ago

Is this one going into rc9 do you know? Thanks!

pelikhan commented 7 years ago

It should be in rc9. Try /beta.

Get Outlook for iOShttps://aka.ms/o0ukef

From: DavidWhaleMEF notifications@github.com Sent: Friday, April 21, 2017 2:26:33 PM To: lancaster-university/microbit-dal Cc: Peli de Halleux; Mention Subject: Re: [lancaster-university/microbit-dal] Pairing with Google Pixel fails (#254)

Is this one going into rc9 do you know? Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flancaster-university%2Fmicrobit-dal%2Fissues%2F254%23issuecomment-296309433&data=02%7C01%7Cjhalleux%40microsoft.com%7C1b13bc7d0108418faa1e08d488fd159f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636284067945397026&sdata=LGsBRHLo1e0XyFqdAbPBqyonD1jjpOGy3j4YUPdnvQQ%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KV2QsITk7OXn1nBAI7z-RIPcsYTsks5ryR8JgaJpZM4LRnQG&data=02%7C01%7Cjhalleux%40microsoft.com%7C1b13bc7d0108418faa1e08d488fd159f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636284067945397026&sdata=CRes9AU8PEs1WtzD4t8QSaz%2FwxGLs%2BPFGWNiDokO3WY%3D&reserved=0.

DavidWhaleMEF commented 7 years ago

Great thanks!

DavidWhaleMEF commented 7 years ago

microbit.org-ticket: 472

DavidWhaleMEF commented 7 years ago

Customer has reported that Google Pixel now pairs successfully with pxt.microbit.org/beta

@finneyj when the appropriate beta goes out to live, can you close this ticket down, ta.

Also shout out to @bluetooth-mdw for the many hours of head scratching and investigation that went into fixing this issue!

Well done team!

DavidWhaleMEF commented 7 years ago

fixed by: pxt.microbit.org version: 0.12.5 Microsoft MakeCode version: 0.12.63 C++ runtime version: v2.0.0-rc9

Currently on pxt.microbit.org/beta