search

lancaster-university / microbit-dal

http://lancaster-university.github.io/microbit-docs
Other
254 stars 130 forks source link

Allocated memory for the PFS buffer dynamically. Saves 60 bytes. #394

Open microbit-sam opened 5 years ago

microbit-sam commented 5 years ago

Please don't merge yet - still need to completely test Partial Flashing

This PR only allocates the large buffer used in partial flashing when it's required

finneyj commented 5 years ago

thanks @microbit-sam. Do you think this is ready to go, or does it need more testing?

microbit-sam commented 5 years ago

I need to test partial flashing still works, running a local instance of MakeCode has changed since I last did it so haven't had time to get it going again

I'll add testing to my Monday todo list

finneyj commented 5 years ago

ACK - thanks.

pelikhan commented 5 years ago

Probably best to have a C++ only test case too.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Joe Finney notifications@github.com Sent: Friday, October 5, 2018 9:29 AM To: lancaster-university/microbit-dal Cc: Subscribed Subject: Re: [lancaster-university/microbit-dal] Allocated memory for the PFS buffer dynamically. Saves 60 bytes. (#394)

ACK - thanks.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flancaster-university%2Fmicrobit-dal%2Fpull%2F394%23issuecomment-427424077&data=02%7C01%7Cjhalleux%40microsoft.com%7Cd6ced7c2189049c6f9cf08d62adfba7b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636743537721736739&sdata=ea2NMGEUZePv%2BvB7dp2%2FXe7Rgo%2FY8X6%2FIW4qidd5Dq8%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KZRuvzM3tFUUZ7xN4QPsNCUboyCAks5uh4jfgaJpZM4XH5MS&data=02%7C01%7Cjhalleux%40microsoft.com%7Cd6ced7c2189049c6f9cf08d62adfba7b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636743537721746756&sdata=7qrBd7nTUMijIOiCoAZgrgDAvPKQuuPWbT9LKx3U438%3D&reserved=0.

microbit-sam commented 5 years ago

Sorry for the delay this week, been testing this afternoon and it's not resetting after flashing. Will update ASAP