search

lancaster-university / microbit-dal

http://lancaster-university.github.io/microbit-docs
Other
256 stars 130 forks source link

Added client_event_write_types config property #413

Open smartyw opened 5 years ago

smartyw commented 5 years ago

Address issue https://github.com/lancaster-university/microbit-dal/issues/411

pelikhan commented 5 years ago

Can we get the changes without the formatting changes? LGTM otherwise.

smartyw commented 5 years ago

Do you mean the tabs vs spaces? I checked with @finneyj and he said the revised formatting was in fact preferred. It wasn't intentional though and seems to be something Visual Studio Code decided to do.

Can I leave it to you (@pelikhan ) and @finneyj to come up with a ruling on formatting rules and let me know?

smartyw commented 5 years ago

I'm still waiting for a response to my previous comment. Anyone? @finneyj ?